Skip to content

Fix for windows and python 3.8 call to add_dll_directory#6742

Merged
atalman merged 1 commit intopytorch:mainfrom
atalman:fix_python38_windows
Oct 11, 2022
Merged

Fix for windows and python 3.8 call to add_dll_directory#6742
atalman merged 1 commit intopytorch:mainfrom
atalman:fix_python38_windows

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Oct 11, 2022 •
edited
Loading

Fix for windows and python 3.8 call to add_dll_directory
Similar to: pytorch/audio#2747

@atalman atalman requested a review from datumbox October 11, 2022 15:36
datumbox
datumbox approved these changes Oct 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@datumbox datumbox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Do we need to cherrypick this into the release?

Let's wait for the tests to complete before merging.

@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Oct 11, 2022

LGTM, thanks! Do we need to cherrypick this into the release?

Let's wait for the tests to complete before merging.

Yes we do need to cherry-pick this. And for sure will wait for this to pass tests

@atalman atalman merged commit 1b5e1b4 into pytorch:main Oct 11, 2022
atalman added a commit to atalman/vision that referenced this pull request Oct 11, 2022
@atalman
Fix for windows and python 3.8 call to add_dll_directory (pytorch#6742)
27822f3
@atalman atalman mentioned this pull request Oct 11, 2022
Open
atalman added a commit that referenced this pull request Oct 11, 2022
@atalman
Fix for windows and python 3.8 call to add_dll_directory (#6742) (#6743)
531a2ea
facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2022
@facebook-github-bot
[fbsync] Fix for windows and python 3.8 call to add_dll_directory (#6742
18b8602 
)

Reviewed By: NicolasHug

Differential Revision: D40427472

fbshipit-source-id: bbcd971213459005e03ea2b0f9e7ff797b7eb228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed enhancement module: ci windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atalman @datumbox @facebook-github-bot