Skip to content

Add video support on MixUp and CutMix#6733

Merged
datumbox merged 4 commits intopytorch:mainfrom
datumbox:prototype/video_cutmix_mixup
Oct 10, 2022
Merged

Add video support on MixUp and CutMix#6733
datumbox merged 4 commits intopytorch:mainfrom
datumbox:prototype/video_cutmix_mixup

Conversation

@datumbox
Copy link
Copy Markdown
Contributor

Fixes #6731

Copy link
Copy Markdown
Contributor Author

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few notes:

Copy link
Copy Markdown
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few inline comments, but otherwise LGTM if CI is green.

@datumbox datumbox requested a review from pmeier October 10, 2022 12:57
@datumbox
Copy link
Copy Markdown
Contributor Author

@pmeier Can you check again? I had to modify the tests

Copy link
Copy Markdown
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch still looks good if CI is happy.

@datumbox datumbox merged commit 12adc54 into pytorch:main Oct 10, 2022
@datumbox datumbox deleted the prototype/video_cutmix_mixup branch October 10, 2022 13:56
facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2022
Summary:
* Add video support on MixUp and CutMix

* Switch back to roll

* Fix tests and mypy

* Another mypy fix

Reviewed By: NicolasHug

Differential Revision: D40427482

fbshipit-source-id: 9e08e6dbc92e845c20c63cafb56f7ba252ed8c5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Video on MixUp and CutMix

3 participants