enable arbitrary batch size for all prototype kernels#6726
Merged
pmeier merged 3 commits intopytorch:mainfrom Oct 10, 2022
Merged
enable arbitrary batch size for all prototype kernels#6726pmeier merged 3 commits intopytorch:mainfrom
pmeier merged 3 commits intopytorch:mainfrom
Conversation
Contributor
Author
Well, no. It was somewhat worse than that: I accidentally removed the |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Summary: * enable arbitrary batch size for all prototype kernels * put back perspective dispatcher Reviewed By: NicolasHug Differential Revision: D40427471 fbshipit-source-id: f8cdfdce28462d72bdb2b92a8606b3eb1ff93d15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6670. This basically only moves the squashing that we did for the video kernels into the image kernels.
If we start to merge transforms v1 and v2, we should support this better. I haven't checked, but I guesstimate that 90% - 100% of all times we need to squash / unsquash is because we use these three ops internally:
vision/torchvision/transforms/functional_tensor.py
Line 469 in 6e203b4
vision/torchvision/transforms/functional_tensor.py
Line 562 in 6e203b4
vision/torchvision/transforms/functional_tensor.py
Line 763 in 6e203b4
I propose, we implement
_nd_{interpolate, grid_sample, conv_2d}as internal utilities, so we don't have to have the arbitrary batch compatibility code everywhere. This is somewhat already implemented for 2. withvision/torchvision/transforms/functional_tensor.py
Line 547 in 6e203b4