Merged
Conversation
YosuaMichael
approved these changes
Oct 5, 2022
Contributor
YosuaMichael
left a comment
There was a problem hiding this comment.
Thanks @pmeier , the change looks good and I agree normally we don't need summary for those that are skipped or expected to fail.
I just have a minor NIT regarding the comment. I will approve first to unblock.
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Summary: * make pytest summary more concise * fix comment Reviewed By: datumbox Differential Revision: D40138725 fbshipit-source-id: 37e67cf39c1a979219eba18de24bbd5d4f9e8b49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently using
vision/pytest.ini
Lines 3 to 4 in a46c4f0
which shows every test that is not passing in the summary. Meaning, skips and xfails are also shown although I'd would wager a guess that no one looks at them. Thus, this PR changes this to only show failures, errors, and xpasses.
Without this, adding markers to the parametrization will render the summary almost useless, since they all get a distinct mention:
-ra:-rfEX:AFAIK, there is currently no occurrence of such pattern in our test suite yet, but will be soon #6653.