cleanup prototype transforms functional tests#6622
Merged
pmeier merged 4 commits intopytorch:mainfrom Sep 22, 2022
Merged
Conversation
vfdev-5
reviewed
Sep 22, 2022
vfdev-5
approved these changes
Sep 22, 2022
This was referenced Sep 22, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
Summary: * cleanup prototype transforms functional tests * fix * oust local functions Reviewed By: NicolasHug Differential Revision: D39765311 fbshipit-source-id: 6351ea0e8ad485c6e03fed18b13d9698d432207e
This was referenced Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the recent changes to our prototype transforms functional test frameworks. It merges the files
test_prototype_transforms_kernels.pyandtest_prototype_transforms_dispatchers.pyintotest_prototype_transforms_functional.pywhile removing any obsolete code in the latter.From here on there are the following tasks that are left to do:
Add
KernelInfo's for the remaining kernelsvision/test/test_prototype_transforms_kernels.py
Lines 33 to 41 in 56e707b
Afterwards, this can also be used to add the
DispatcherInfo's.Add dispatch tests for the dispatchers. Basically we need to make sure that
PIL.Image.Imagegets passed, we dispatch to the PIL kernel_Featureis passed we dispatch to the feature methodReduce the number of sample inputs since they are used for multiple tests:
Overview
Port the remaining correctness tests into references of the new framework.