Merged
Conversation
24 tasks
NicolasHug
approved these changes
May 20, 2022
Member
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM.
For my own understanding, do we need a Permute module, or could we just rely on torch.permute? Looks like tihs Permute is a very simple wrapper
Contributor
Author
|
@NicolasHug you are right that Another alternative is to move it to some |
Contributor
Author
|
As discussed offline with @NicolasHug, it's OK to have this as an op. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
Reviewed By: NicolasHug Differential Revision: D36760916 fbshipit-source-id: e71606bcdb48b74adf65c1def01c8f1ded22f8b7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving #6053 (comment)