Skip to content

Adding FixedSizeCrop transform#5607

Merged
datumbox merged 2 commits intopytorch:mainfrom
datumbox:transforms/fixed_size_crop
Mar 14, 2022
Merged

Adding FixedSizeCrop transform#5607
datumbox merged 2 commits intopytorch:mainfrom
datumbox:transforms/fixed_size_crop

Conversation

@datumbox
Copy link
Copy Markdown
Contributor

@datumbox datumbox commented Mar 14, 2022 •
edited
Loading

Cherrypicking from #5444 the FixedSizeCrop.

The specific transform is used in combination with the Large Scale Jitter to improve the accuracy of the *RCNN models.

@datumbox datumbox requested a review from vfdev-5 March 14, 2022 14:02
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 14, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit cdd24a8 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

vfdev-5
vfdev-5 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks @datumbox

@datumbox datumbox merged commit 5ddd564 into pytorch:main Mar 14, 2022
@datumbox datumbox deleted the transforms/fixed_size_crop branch March 14, 2022 14:39
@datumbox datumbox mentioned this pull request Mar 14, 2022
Closed
24 tasks
facebook-github-bot pushed a commit that referenced this pull request Mar 15, 2022
@datumbox @facebook-github-bot
[fbsync] Adding FixedSizeCrop transform (#5607)
7baeda8 
Reviewed By: vmoens

Differential Revision: D34878981

fbshipit-source-id: 1c7447de95c9ccf4ddc5c41b0a4caec05ebd8692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/default cla signed module: reference scripts module: transforms new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@datumbox @facebook-github-bot @vfdev-5