Simplify EMA to use Pytorch's update_parameters#5469
Merged
datumbox merged 4 commits intopytorch:mainfrom Feb 27, 2022
xiaohu2015:patch-1
Merged
Simplify EMA to use Pytorch's update_parameters#5469datumbox merged 4 commits intopytorch:mainfrom xiaohu2015:patch-1
datumbox merged 4 commits intopytorch:mainfrom
xiaohu2015:patch-1
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 31b0e04 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
24 tasks
datumbox
approved these changes
Feb 27, 2022
Contributor
datumbox
left a comment
There was a problem hiding this comment.
@xiaohu2015 Thanks a lot for the contribution and for providing a snippet that verifies that the implementation works fine. I think we can merge this. :)
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Reviewed By: datumbox Differential Revision: D34579515 fbshipit-source-id: 6f563a48305dc1c9d99274d40c15416075c9b20f
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is about #5284.
with torch nightly version
1.12.0.dev20220225+cu113, it runs OK: