add EuroSAT prototype dataset#5452
Conversation
💊 CI failures summary and remediationsAs of commit 5b34400 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR @Dbhasin1! I only have some style nit inline. Apart from that, we should also add a test for the dataset. To do that you add a
@register_mock
def eurosat(info, root, config):
...to the file test/builtin_dataset_mocks.py. The body of this function should generate mock data in the same structure of the original dataset, but with only a few samples. Luckily, we already have this functionality for the old dataset in
Lines 2176 to 2190 in c530b62
Thus, you only need to port this as well to the new architecture. Let me know if you face any issues with that.
NicolasHug
left a comment
There was a problem hiding this comment.
stamping, thanks @Dbhasin1
Summary: * add eurosat * revert formatting * port test and make style changes * add eurosat to __init__ * fix pathlib error * create dataset zipfile and revert pre commit changes * remove unecessary variable in resources * revert auto formatter changes and modify ufmt version * revert change to contributing guide Reviewed By: vmoens Differential Revision: D34878968 fbshipit-source-id: 845347b981c85fff13111f77a33119181f863829 Co-authored-by: Dbhasin1 <drishti_b@me.iitr.c.in> Co-authored-by: Nicolas Hug <nicolashug@fb.com>
fixes #5338