Merged
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 0791dfc (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
14 tasks
pmeier
reviewed
Jan 10, 2022
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
pmeier
reviewed
Jan 12, 2022
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
zhiqwang
commented
Jan 12, 2022
NicolasHug
reviewed
Jan 12, 2022
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks a lot @zhiqwang for the PR, and @pmeier for the review.
I made some very minor changes above, the only relevant one is that I changed split="valid" into split="val" for more consistency with other datasets.
This LGTM but I just have one question below regarding the download logic, LMK what you think
pmeier
reviewed
Jan 12, 2022
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
NicolasHug
approved these changes
Jan 12, 2022
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks a lot @zhiqwang !! Will merge when green
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
Summary: * Add Flowers102 datasets * Fix initialization of images and labels * Fix _check_exists in Flowers102 * Add Flowers102 to datasets and docs * Add Flowers102TestCase to unittest * Fixing Python type statically * Shuffle the fake labels * Update test/test_datasets.py * Apply the suggestions by pmeier * Use check_integrity to check file existence * Save the labels to base_folder * Minor fixes * Using a loop makes this more concise without reducing readability * Using a loop makes this more concise without reducing readability * Remove self.labels and self.label_to_index attributes * minor simplification * Check the exitence of image folder * Revert the check * Check the existence of image folder * valid -> val * keep some stuff private * minor doc arrangements * remove default FEATURE_TYPES * Simplify the datasets existence * check if the image folder exists * isdir -> is_dir Reviewed By: NicolasHug Differential Revision: D33618165 fbshipit-source-id: ecf9e44202f58bf7a5233248d5471d464efd6644 Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Nicolas Hug <nicolashug@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Flowers102 dataset in #5108.
cc @pmeier @NicolasHug