Conversation
💊 CI failures summary and remediationsAs of commit a3a7f12 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
will also fix this: #1654 |
|
Another frequent dataset for metric learning is Stanford Online Products... |
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @pmeier , some minor comments / questions but LGTM
| bounding_box=BoundingBox( | ||
| [int(content["bbox"][coord]) for coord in ("left", "bottom", "right", "top")], format="xyxy" | ||
| ), | ||
| segmentation=Feature(content["seg"]), |
There was a problem hiding this comment.
Could you help me understand why we use the decoder for the Feature(...) in _2011_decode_ann, but not in this function?
There was a problem hiding this comment.
The decoder is used to turn an open file handle into a the pixel values as tensor. In this case the raw pixel values are already present as a numpy.ndarray so there is nothing left to decode.
|
Test failure is unrelated. |
|
I guess it would be nice to include some okay metric learning tutorial / reference impl using CUB/Stanford Online Products, this could be a useful example of new-style dataset usage (I've had a bit simplified but working impl of https://arxiv.org/abs/1706.07567 in https://github.com/vadimkantorov/metriclearningbench) |
Summary: * add CUB200 prototype datasets * address review comments Reviewed By: NicolasHug Differential Revision: D33618169 fbshipit-source-id: d2212728e21578eacdad9a186a5638750fbe3f79
This is the only popular vision dataset (according to this list) that we are currently missing.
cc @pmeier @bjuncek