Adds EuroSAT to the list of supported datasets#5114
Merged
NicolasHug merged 23 commits intopytorch:mainfrom Jan 18, 2022
Merged
Adds EuroSAT to the list of supported datasets#5114NicolasHug merged 23 commits intopytorch:mainfrom
NicolasHug merged 23 commits intopytorch:mainfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit fad24b8 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
reviewed
Dec 19, 2021
14 tasks
pmeier
reviewed
Dec 20, 2021
Contributor
pmeier
left a comment
There was a problem hiding this comment.
Looking good. A small nits inline. Other than that, I propose we use at least a somewhat standardized naming scheme for the folders. I would use base_folder as the root folder plus the dataset name and data_folder as the folder that gets extracted from the archive. For an example, have a look at #5115.
pmeier
approved these changes
Dec 21, 2021
NicolasHug
reviewed
Jan 5, 2022
Contributor
|
@frgfm the test failures are related. Could you have a look? |
Contributor
Author
Oops, I overlooked that one. This should be fixed now 👍 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
Summary: * feat: Added EuroSAT dataset * test: Added unittest * docs: Improved comments * docs: Updated the documentation * docs: Removed unnecessary comments * fix: Fixed class implementation * test: Fixed unittest * fix: Fixed magic method len * test: Fixed unittest * refactor: Refactored EuroSAT * refactor: Applied modifications * Apply suggestions from code review * refactor: Applied request changes * refactor: Made var explicit * fix: Fixed attribute initialization order * refactor: Removed name mapping Reviewed By: datumbox, NicolasHug Differential Revision: D33655260 fbshipit-source-id: 0986a3914c8ad89d3fc54792e53e64f420331746 Co-authored-by: Philip Meier <github.pmeier@posteo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #5108, this PR introduces the following modifications:
Any feedback is welcome!
cc @pmeier