Skip flaky check for quantized resnet50#4686
Merged
datumbox merged 2 commits intopytorch:mainfrom Oct 21, 2021
Merged
Conversation
prabhat00155
approved these changes
Oct 21, 2021
Contributor
prabhat00155
left a comment
There was a problem hiding this comment.
Thanks @datumbox, looks good to me.
NicolasHug
approved these changes
Oct 21, 2021
Member
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM too, thanks
Fix #4683
I think we'll need to remove this to keep the issue open so that we don't forget that this is something that needs to be looked at
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
#4686) Reviewed By: NicolasHug Differential Revision: D31916329 fbshipit-source-id: ae12373b2f1bd9dfaffcf06bc02813a4885c378a
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4683
It's a temporary measure until we fix the overall flakiness of the model tests.
cc @pmeier