Do not disable profiling executor in ONNX tests#4322
Merged
datumbox merged 1 commit intogh/bertmaher/1/basefrom Aug 26, 2021
Merged
Do not disable profiling executor in ONNX tests#4322datumbox merged 1 commit intogh/bertmaher/1/basefrom
datumbox merged 1 commit intogh/bertmaher/1/basefrom
Conversation
[ghstack-poisoned]
datumbox
approved these changes
Aug 26, 2021
Contributor
datumbox
left a comment
There was a problem hiding this comment.
LGTM, thanks for your help investigating and resolving this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4314. Toggling the profiling executor on and off within a test suite is fairly dangerous; the two aren't supposed to intermingle, and the PE should be stable at this point.
Stack from ghstack: