Add StochasticDepth implementation#4301
Merged
datumbox merged 11 commits intopytorch:masterfrom Aug 20, 2021
Merged
Conversation
NicolasHug
reviewed
Aug 20, 2021
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @datumbox ! I made a brief review with some questions, but this looks good
fmassa
approved these changes
Aug 20, 2021
Member
fmassa
left a comment
There was a problem hiding this comment.
Looks great, thanks a lot!
I have some small comments, let me know what you think. None of those are merge-blocking, so I'm approving it.
Also, I think you need to add an entry in https://github.com/pytorch/vision/blob/master/docs/source/ops.rst for it to appear in the documentation
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Contributor
Author
|
Thanks both for the fast review. I believe I addressed all comments. I'll merge after the tests pass. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
Summary: * Adding operator. * Adding tests * switching order of `p` and `mode`. * Remove seed setting. * Replace stats import with pytest.importorskip. * Fix doc * Apply suggestions from code review * Fixing indentation. * Adding operator in the documentation. * Fixing lint Reviewed By: fmassa Differential Revision: D30525891 fbshipit-source-id: da8300c8428efa8f74d79ae06c19ea2e040c88c9 Co-authored-by: Francisco Massa <fvsmassa@gmail.com> Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4298