Removing VISION_API from backward() methods and adding an ops.h#3163
Merged
fmassa merged 2 commits intopytorch:masterfrom Dec 14, 2020
Merged
Removing VISION_API from backward() methods and adding an ops.h#3163fmassa merged 2 commits intopytorch:masterfrom
fmassa merged 2 commits intopytorch:masterfrom
Conversation
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #3163 +/- ##
=======================================
Coverage 72.79% 72.79%
=======================================
Files 98 98
Lines 8964 8964
Branches 1430 1430
=======================================
Hits 6525 6525
Misses 1992 1992
Partials 447 447 Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
Summary: * Removing VISION_API from backward() methods and adding a ops.h * Fixing clang format. Reviewed By: datumbox Differential Revision: D25531032 fbshipit-source-id: a9241ac53196ca14647002a29c476909b50ee064
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor clean ups on the ops implementations:
VISION_API.opsis missing anops.hthat conveniently adds all operator headers.imagesandmodelsnamespaces have similar header files, so I add one for ops as well.