Removed all backward methods from header files#3143
Merged
fmassa merged 1 commit intopytorch:masterfrom Dec 9, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3143 +/- ##
=======================================
Coverage 72.75% 72.75%
=======================================
Files 99 99
Lines 8979 8979
Branches 1431 1431
=======================================
Hits 6533 6533
Misses 1999 1999
Partials 447 447 Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 10, 2020
Reviewed By: fmassa Differential Revision: D25460678 fbshipit-source-id: 708f1a57091bed84381895184ae77a866eb1762b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3135 keeping the backward methods public is unnecessary, so this PR removes them.