Encapsulate and Standardise C++ Ops (#3097)#3133
Closed
fmassa wants to merge 2 commits intopytorch:fbsyncfrom
Closed
Encapsulate and Standardise C++ Ops (#3097)#3133fmassa wants to merge 2 commits intopytorch:fbsyncfrom
fmassa wants to merge 2 commits intopytorch:fbsyncfrom
Conversation
* Encapsulate and standardize deform_conv2d (pytorch#3074) * Rename files. * Standardizing method names. * Adding anonymous namespaces. * Applying C++ naming rules and alinging variable names across headers and cpp files. * Syncing names across implementations. * Rename deform_conv2d.h to deform_conv2d.cpp * Use header files: - Create header files for kernel implementation and remove definitions from vision_*.h files. - Eliminate unnecessary headers and ensure all cpp include their headers. * Change the naming convention for kernel implementations. * Remove the _param postfix from the variables and standardizing names. * Exposing public forward/backward methods to the C++ API and moving methods around to minimize git blame changes. * Encapsulate and standardize nms (pytorch#3081) * Syncing, where possible, the names of functions across devices. * Adding all internal functions in anonymous namespaces. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Update CMakeLists.txt to include all headers. * Encapsulate and standardize ps_roi_align (pytorch#3082) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. Syncing, where possible, the names of functions across devices. * Adding all internal functions in anonymous namespaces. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Encapsulate and standardize ps_roi_pool (pytorch#3084) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. * Adding all internal functions in anonymous namespaces. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Encapsulate and standardize roi_align (pytorch#3085) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. * Adding all internal functions in anonymous namespaces. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Encapsulate and standardize roi_pool (pytorch#3088) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. * Adding all internal functions in anonymous namespaces. * Syncing variable names between the cpp files and their header files. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Encapsulate and standardize new_empty_tensor_op (pytorch#3089) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. * Create foreach cpp file a separate header file with "public" functions. * Adding all internal functions in anonymous namespaces. * Convert to const ref all possible parameters. * Removing unnecessary repeated includes. * Encapsulate and standardize C++ Ops - Clean up (pytorch#3094) * Removing unnecessary repeated includes. * Remove unnecessary vision_cpu.h, vision_cuda.h, autocast.h. * Fixing naming convention and correcting method names on macros. * Turn on clang formatter for cu files and fixing broken styles. * Replace "#ifndef ... #define ... #endif" with "#pragma once" on header files. * Adding operator methods in vision::ops namespace. (pytorch#3096) * Adding operator methods in vision::ops namespace. * Replace general.h with macros.h * Adding vision.h to the necessary cpp files.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fmassa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fmassa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
datumbox
approved these changes
Dec 7, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 8, 2020
Summary: * Encapsulate and standardize deform_conv2d (#3074) * Rename files. * Standardizing method names. * Adding anonymous namespaces. * Applying C++ naming rules and alinging variable names across headers and cpp files. * Syncing names across implementations. * Rename deform_conv2d.h to deform_conv2d.cpp * Use header files: - Create header files for kernel implementation and remove definitions from vision_*.h files. - Eliminate unnecessary headers and ensure all cpp include their headers. * Change the naming convention for kernel implementations. * Remove the _param postfix from the variables and standardizing names. * Exposing public forward/backward methods to the C++ API and moving methods around to minimize git blame changes. * Encapsulate and standardize nms (#3081) * Syncing, where possible, the names of functions across devices. * Adding all internal functions in anonymous namespaces. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Update CMakeLists.txt to include all headers. * Encapsulate and standardize ps_roi_align (#3082) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. Syncing, where possible, the names of functions across devices. * Adding all internal functions in anonymous namespaces. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Encapsulate and standardize ps_roi_pool (#3084) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. * Adding all internal functions in anonymous namespaces. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Encapsulate and standardize roi_align (#3085) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. * Adding all internal functions in anonymous namespaces. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Encapsulate and standardize roi_pool (#3088) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. * Adding all internal functions in anonymous namespaces. * Syncing variable names between the cpp files and their header files. * Renaming C++/CUDA kernel files and moving operator code from header to cpp file. * Create foreach cpp file a separate header file with "public" functions. * Removing unnecessary repeated includes. * Encapsulate and standardize new_empty_tensor_op (#3089) * Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API. * Create foreach cpp file a separate header file with "public" functions. * Adding all internal functions in anonymous namespaces. * Convert to const ref all possible parameters. * Removing unnecessary repeated includes. * Encapsulate and standardize C++ Ops - Clean up (#3094) * Removing unnecessary repeated includes. * Remove unnecessary vision_cpu.h, vision_cuda.h, autocast.h. * Fixing naming convention and correcting method names on macros. * Turn on clang formatter for cu files and fixing broken styles. * Replace "#ifndef ... #define ... #endif" with "#pragma once" on header files. * Adding operator methods in vision::ops namespace. (#3096) * Adding operator methods in vision::ops namespace. * Replace general.h with macros.h * Adding vision.h to the necessary cpp files. Pull Request resolved: #3133 Reviewed By: datumbox Differential Revision: D25369675 Pulled By: fmassa fbshipit-source-id: 36b57ed735394a799f744ce161f2667c5f6c95c2
Member
Author
|
Merged in 63b9b61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encapsulate and standardize deform_conv2d (Encapsulate and standardize deform_conv2d #3074)
Rename files.
Standardizing method names.
Adding anonymous namespaces.
Applying C++ naming rules and alinging variable names across headers and cpp files.
Syncing names across implementations.
Rename deform_conv2d.h to deform_conv2d.cpp
Use header files:
Change the naming convention for kernel implementations.
Remove the _param postfix from the variables and standardizing names.
Exposing public forward/backward methods to the C++ API and moving methods around to minimize git blame changes.
Encapsulate and standardize nms (Encapsulate and standardize nms #3081)
Syncing, where possible, the names of functions across devices.
Adding all internal functions in anonymous namespaces.
Renaming C++/CUDA kernel files and moving operator code from header to cpp file.
Create foreach cpp file a separate header file with "public" functions.
Removing unnecessary repeated includes.
Update CMakeLists.txt to include all headers.
Encapsulate and standardize ps_roi_align (Encapsulate and standardize ps_roi_align #3082)
Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.
Syncing, where possible, the names of functions across devices.
Adding all internal functions in anonymous namespaces.
Renaming C++/CUDA kernel files and moving operator code from header to cpp file.
Create foreach cpp file a separate header file with "public" functions.
Removing unnecessary repeated includes.
Encapsulate and standardize ps_roi_pool (Encapsulate and standardize ps_roi_pool #3084)
Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.
Adding all internal functions in anonymous namespaces.
Renaming C++/CUDA kernel files and moving operator code from header to cpp file.
Create foreach cpp file a separate header file with "public" functions.
Removing unnecessary repeated includes.
Encapsulate and standardize roi_align (Encapsulate and standardize roi_align #3085)
Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.
Adding all internal functions in anonymous namespaces.
Renaming C++/CUDA kernel files and moving operator code from header to cpp file.
Create foreach cpp file a separate header file with "public" functions.
Removing unnecessary repeated includes.
Encapsulate and standardize roi_pool (Encapsulate and standardize roi_pool #3088)
Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.
Adding all internal functions in anonymous namespaces.
Syncing variable names between the cpp files and their header files.
Renaming C++/CUDA kernel files and moving operator code from header to cpp file.
Create foreach cpp file a separate header file with "public" functions.
Removing unnecessary repeated includes.
Encapsulate and standardize new_empty_tensor_op (Encapsulate and standardize new_empty_tensor_op #3089)
Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.
Create foreach cpp file a separate header file with "public" functions.
Adding all internal functions in anonymous namespaces.
Convert to const ref all possible parameters.
Removing unnecessary repeated includes.
Encapsulate and standardize C++ Ops - Clean up (Encapsulate and standardize C++ Ops - Clean up #3094)
Removing unnecessary repeated includes.
Remove unnecessary vision_cpu.h, vision_cuda.h, autocast.h.
Fixing naming convention and correcting method names on macros.
Turn on clang formatter for cu files and fixing broken styles.
Replace "#ifndef ... #define ... #endif" with "#pragma once" on header files.
Adding operator methods in vision::ops namespace. (Adding operator methods in vision::ops namespace. #3096)
Adding operator methods in vision::ops namespace.
Replace general.h with macros.h
Adding vision.h to the necessary cpp files.