[Tensor Parallel] update tutorial to simplify embedding + first transformer block#2871
Merged
tianyu-l merged 2 commits intogh/tianyu-l/1/basefrom May 16, 2024
Merged
[Tensor Parallel] update tutorial to simplify embedding + first transformer block#2871tianyu-l merged 2 commits intogh/tianyu-l/1/basefrom
tianyu-l merged 2 commits intogh/tianyu-l/1/basefrom
Conversation
…former block [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2871
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a4cd3e5 with merge base 9e1f001 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
tianyu-l
added a commit
to pytorch/examples
that referenced
this pull request
May 16, 2024
…first transformer block" Following changes in pytorch/torchtitan#314, to apply a reduce-scatter instead of the more expensive all-reduce + local chunk. cross PR with pytorch/tutorials#2871 [ghstack-poisoned]
…first transformer block" cross PR with pytorch/examples#1259 [ghstack-poisoned]
svekars
approved these changes
May 16, 2024
wanchaol
approved these changes
May 16, 2024
Contributor
wanchaol
left a comment
There was a problem hiding this comment.
lgtm! Thanks for updating!
Contributor
Author
Contributor
|
Sorry we don't support gh-stack in this repo, I approved #2872 and you should be able to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cross PR with pytorch/examples#1259