This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Move predictor into caffe2/caffe2/predictor#157
Closed
yic-e wants to merge 1 commit intopytorch:masterfrom
yic-e:export-D8845276
Closed
Move predictor into caffe2/caffe2/predictor#157yic-e wants to merge 1 commit intopytorch:masterfrom yic-e:export-D8845276
yic-e wants to merge 1 commit intopytorch:masterfrom
yic-e:export-D8845276
Conversation
Contributor
|
Have these header files already been moved (or will be soon)? It seems they're still under https://github.com/pytorch/pytorch/tree/master/caffe2/core ? Also, have those changes already been propagated to the latest pytorch-caffe2* conda packages under https://anaconda.org/caffe2 ? |
|
hm, looks like the implementation file was not moved as part of the diff somehow |
Contributor
Author
|
I have another pr pytorch/pytorch#9548 for the rest of the changes there. Maybe I should land that first and then this one. |
Summary: Pull Request resolved: pytorch/pytorch#9548 Pull Request resolved: #157 One part of refactor predictor. Move all the files into predictor dir. Differential Revision: D8845276 fbshipit-source-id: 4e42c8874c7443422b5c1a94fda47bbcf4d85309
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 27, 2018
Summary: Pull Request resolved: #9548 Pull Request resolved: pytorch/translate#157 One part of refactor predictor. Move all the files into predictor dir. Reviewed By: highker Differential Revision: D8845276 fbshipit-source-id: 1e917464b0c8a042f025128a082c784eaa3b7013
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9548 Pull Request resolved: pytorch/translate#157 One part of refactor predictor. Move all the files into predictor dir. Reviewed By: highker Differential Revision: D8845276 fbshipit-source-id: 1e917464b0c8a042f025128a082c784eaa3b7013
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9548 Pull Request resolved: pytorch/translate#157 One part of refactor predictor. Move all the files into predictor dir. Reviewed By: highker Differential Revision: D8845276 fbshipit-source-id: 1e917464b0c8a042f025128a082c784eaa3b7013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: One part of refactor predictor. Move all the files into predictor dir.
Differential Revision: D8845276