Conversation
PyTorch trunk has an offensive PR that breaks CP. It is better to get tests signals from other parallelisms than no signals.
tianyu-l
approved these changes
Feb 27, 2025
Contributor
|
Hi @fegin , could you point out the PR link of PyTorch which broke the result of CP ? THX ! |
Contributor
|
@xingchensong likely it's pytorch/pytorch#146372 |
fegin
pushed a commit
that referenced
this pull request
Mar 3, 2025
…as been fixed (#912) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #912 ### Summary This PR undo #898 and re-enables CP tests in CI as pytorch/pytorch#148125 fixed the DTensor sdp flash attention op. ### Test CI
fegin
added a commit
that referenced
this pull request
Mar 3, 2025
#921) …as been fixed (#912) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #912 ### Summary This PR undo #898 and re-enables CP tests in CI as pytorch/pytorch#148125 fixed the DTensor sdp flash attention op. ### Test CI Co-authored-by: Xilun Wu <12968408+XilunWu@users.noreply.github.com>
MaxiBoether
pushed a commit
to eth-easl/torchtitan-mixtera
that referenced
this pull request
Apr 17, 2025
PyTorch trunk has an offensive PR that breaks CP. It is better to get tests signals from other parallelisms than no signals.
MaxiBoether
pushed a commit
to eth-easl/torchtitan-mixtera
that referenced
this pull request
Apr 17, 2025
pytorch#921) …as been fixed (pytorch#912) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ pytorch#912 ### Summary This PR undo pytorch#898 and re-enables CP tests in CI as pytorch/pytorch#148125 fixed the DTensor sdp flash attention op. ### Test CI Co-authored-by: Xilun Wu <12968408+XilunWu@users.noreply.github.com>
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 13, 2026
PyTorch trunk has an offensive PR that breaks CP. It is better to get tests signals from other parallelisms than no signals.
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 13, 2026
pytorch#921) …as been fixed (pytorch#912) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ pytorch#912 ### Summary This PR undo pytorch#898 and re-enables CP tests in CI as pytorch/pytorch#148125 fixed the DTensor sdp flash attention op. ### Test CI Co-authored-by: Xilun Wu <12968408+XilunWu@users.noreply.github.com>
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 25, 2026
PyTorch trunk has an offensive PR that breaks CP. It is better to get tests signals from other parallelisms than no signals.
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 25, 2026
pytorch#921) …as been fixed (pytorch#912) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ pytorch#912 ### Summary This PR undo pytorch#898 and re-enables CP tests in CI as pytorch/pytorch#148125 fixed the DTensor sdp flash attention op. ### Test CI Co-authored-by: Xilun Wu <12968408+XilunWu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch trunk has an offensive PR that breaks CP. It is better to get tests signals from other parallelisms than no signals.