Merged
Conversation
ruisizhang123
approved these changes
Oct 25, 2025
Contributor
ruisizhang123
left a comment
There was a problem hiding this comment.
Nice catch, thank you for the fix!
jquesnelle
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Nov 10, 2025
pytorch#1813 added `job_config.compile.model_backend_override` to override configs via `--job.custom_config_module=torchtitan.experiments.simple_fsdp.job_config --compile.model_backend_override "aot_eager_autobucketing"`. However, other commands without override would break, since `job_config.compile.model_backend_override` is undefined. This PR fixes the issue.
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 13, 2026
pytorch#1813 added `job_config.compile.model_backend_override` to override configs via `--job.custom_config_module=torchtitan.experiments.simple_fsdp.job_config --compile.model_backend_override "aot_eager_autobucketing"`. However, other commands without override would break, since `job_config.compile.model_backend_override` is undefined. This PR fixes the issue.
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 25, 2026
pytorch#1813 added `job_config.compile.model_backend_override` to override configs via `--job.custom_config_module=torchtitan.experiments.simple_fsdp.job_config --compile.model_backend_override "aot_eager_autobucketing"`. However, other commands without override would break, since `job_config.compile.model_backend_override` is undefined. This PR fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1813 added
job_config.compile.model_backend_overrideto override configs via--job.custom_config_module=torchtitan.experiments.simple_fsdp.job_config --compile.model_backend_override "aot_eager_autobucketing".However, other commands without override would break, since
job_config.compile.model_backend_overrideis undefined. This PR fixes the issue.