remove float8 force_recompute_fp8_weight_in_bwd flag#1452
Merged
Conversation
tianyu-l
approved these changes
Jul 24, 2025
tianyu-l
left a comment
Contributor
There was a problem hiding this comment.
please address one comment I have.
| --model.converters="float8" \ | ||
| --float8.enable_fsdp_float8_all_gather \ | ||
| --float8.precompute_float8_dynamic_scale_for_fsdp \ | ||
| --float8.force_recompute_fp8_weight_in_bwd \ |
Contributor
There was a problem hiding this comment.
We probably shouldn't delete this.
The benchmark was run with a pinned commit in torchao. If people needs to reproduce with the old commit, they still need this field, right?
Summary: This flag has been deprecated in pytorch/ao#2356, deleting it from torchtitan to prepare for future deletion from torchao. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
36fdff1 to
2f3bf86
Compare
Luosuu
pushed a commit
to Luosuu/torchtitan
that referenced
this pull request
Jul 28, 2025
Summary: This flag has been deprecated in pytorch/ao#2356, deleting it from torchtitan to prepare for future deletion from torchao. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
bentherien
pushed a commit
to bentherien/torchtitan_
that referenced
this pull request
Aug 5, 2025
Summary: This flag has been deprecated in pytorch/ao#2356, deleting it from torchtitan to prepare for future deletion from torchao. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
joellidin
pushed a commit
to one-covenant/torchtitan
that referenced
this pull request
Aug 8, 2025
Summary: This flag has been deprecated in pytorch/ao#2356, deleting it from torchtitan to prepare for future deletion from torchao. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
joellidin
pushed a commit
to one-covenant/torchtitan
that referenced
this pull request
Aug 8, 2025
Summary: This flag has been deprecated in pytorch/ao#2356, deleting it from torchtitan to prepare for future deletion from torchao. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 13, 2026
Summary: This flag has been deprecated in pytorch/ao#2356, deleting it from torchtitan to prepare for future deletion from torchao. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 25, 2026
Summary: This flag has been deprecated in pytorch/ao#2356, deleting it from torchtitan to prepare for future deletion from torchao. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This flag has been deprecated in
pytorch/ao#2356,
deleting it from torchtitan to prepare for future deletion from torchao.
Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: