ci: Pin more nvidia-container dependencies#6637
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
wdvr
approved these changes
May 16, 2025
malfet
approved these changes
May 16, 2025
Contributor
|
I wonder whether the following installation sequence would be any better: |
atalman
pushed a commit
to atalman/test-infra
that referenced
this pull request
May 20, 2025
This pull request updates the `.github/actions/setup-nvidia/action.yml` file to enhance the NVIDIA container setup process by including additional dependencies for better compatibility and functionality. Enhancements to NVIDIA container setup: * Updated the `yum install` command to include additional packages: `libnvidia-container-tools-1.16.2`, `libnvidia-container1-1.16.2`, and `nvidia-container-toolkit-base-1.16.2`, alongside the existing `nvidia-docker2` and `nvidia-container-toolkit-1.16.2`. This ensures a more complete installation of NVIDIA container tools.
malfet
pushed a commit
that referenced
this pull request
May 20, 2025
elezar
reviewed
May 22, 2025
| sudo yum-config-manager --add-repo "${YUM_REPO_URL}" | ||
| sudo yum install -y nvidia-docker2 nvidia-container-toolkit-1.16.2 | ||
| sudo yum install -y \ | ||
| nvidia-docker2 \ |
There was a problem hiding this comment.
As a note: nvidia-docker2 can be removed. It is an empty package that only serves to introduce a dependency on the nvidia-container-toolkit package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
.github/actions/setup-nvidia/action.ymlfile to enhance the NVIDIA container setup process by including additional dependencies for better compatibility and functionality.Enhancements to NVIDIA container setup:
yum installcommand to include additional packages:libnvidia-container-tools-1.16.2,libnvidia-container1-1.16.2, andnvidia-container-toolkit-base-1.16.2, alongside the existingnvidia-docker2andnvidia-container-toolkit-1.16.2. This ensures a more complete installation of NVIDIA container tools.