Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
No ciflow labels are configured for this repo. |
.github/workflows/linux_job.yml
Outdated
| if: ${{ inputs.rocm == false }} | ||
|
|
||
| - name: Setup ROCm | ||
| uses: amdfaa/pytorch/.github/actions/setup-rocm@torchao_experiment |
Collaborator
There was a problem hiding this comment.
Temporary change until pytorch/pytorch#143590 is merged
| env_file = f"{ os.environ.get('RUNNER_TEMP', '') }/github_env_{ os.environ.get('GITHUB_RUN_ID', '') }" | ||
| if f"{ os.environ.get('ROCM', '') }" == "true": | ||
| env_file = f"/tmp/github_env_{ os.environ.get('GITHUB_RUN_ID', '') }" | ||
|
|
Collaborator
There was a problem hiding this comment.
This shouldn't be needed if we update setup-rocm.yml to export all the required env vars to ${RUNNER_TEMP}/github_env_${GITHUB_RUN_ID} like in actions/setup-linux/action.yml
jithunnair-amd
requested changes
Dec 19, 2024
| -v "{ os.environ.get('RUNNER_TEST_RESULTS_DIR', '') }:/test-results" \ | ||
| -v "{ os.environ.get('RUNNER_TEMP', '') }/artifacts:/artifacts" \ | ||
| -v "{ os.environ.get('RUNNER_TEMP', '') }/docs:/docs" \ | ||
| -v "{ os.environ.get('RUNNER_TEMP', '') }/test-results:/test-results" \ |
Collaborator
There was a problem hiding this comment.
Let's define these RUNNER_ env vars in setup-rocm.yml similar to
.github/workflows/linux_job.yml
Outdated
| docker-image: | ||
| description: Identifies the Docker image by name. | ||
| default: "pytorch/conda-builder" | ||
| default: "pytorch/almalinux-builder" |
Collaborator
There was a problem hiding this comment.
Let's make changes to linux_job_v2.yml instead, which already has these almalinux-based changes, so the only updates would be for the ROCm conditionalization.
379b577 to
998e2f9
Compare
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 20, 2024
Needed for pytorch/test-infra#6003 and pytorch/ao#999 Pull Request resolved: #143590 Approved by: https://github.com/atalman Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
998e2f9 to
4796068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to pytorch/ao#999
This PR has been closed in favor of: #6104