Skip to content

Use Almalinux-builder in linux-job by default#5898

Merged
atalman merged 3 commits intopytorch:mainfrom
atalman:linux_job_v2
Nov 12, 2024
Merged

Use Almalinux-builder in linux-job by default#5898
atalman merged 3 commits intopytorch:mainfrom
atalman:linux_job_v2

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Nov 12, 2024 •
edited
Loading

Use image build by: pytorch/pytorch#140157
This should support both Manylinux 2.28 wheels and old glibc 2.26 wheels. Tested by pulling Docker images and running some test.

Test:

docker pull pytorch/almalinux-builder:cpu-main

Test Wheel build with Manylinux 2.28:

>>> import torch
>>> from torch._C import *
>>> torch.__version__
'2.6.0.dev20241106+cpu'

Test Wheel build with manylinux-builder:

>>> import torch
>>> torch.__version__
'2.5.1+cu124'
>>> from torch._C import *

Example of Glibc failure with wheels from 2024.11.06: https://github.com/pytorch/tensordict/actions/runs/11708894033/job/32611711890#step:12:734

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Nov 12, 2024

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@atalman atalman changed the title Add linux-job v2 Use Almalinux-builder in linux-job by default Nov 12, 2024
ZainRizvi
ZainRizvi reviewed Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. What's special about almalinux?
  2. Why are the secrets jobs failing?

@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Nov 12, 2024

Almalinux is a new platform we would like to replace conda-builder with. It supports both old wheels and new wheels build with Manylinx 2.28. This is directly related to Manylinx 2.28 migration

@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Nov 12, 2024 •
edited
Loading

Secrets job failures, are not related to this PR. We would need to investigate the failure: #5899

ZainRizvi
ZainRizvi approved these changes Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, those tests seem to consistently fail when you change the base image, but other PRs on trunk remained green afterwards.

https://github.com/pytorch/test-infra/actions/workflows/test_linux_job.yml

Approving the PR since the failure seems linked to the container changing to any other container

@atalman atalman merged commit 10cfd7c into pytorch:main Nov 12, 2024
atalman added a commit that referenced this pull request Nov 12, 2024
@atalman
Revert "Use Almalinux-builder in linux-job by default (#5898)"
3cbd3d0 
This reverts commit 10cfd7c.
@atalman atalman mentioned this pull request Nov 12, 2024
Merged
atalman added a commit that referenced this pull request Nov 12, 2024
@atalman
Revert "Use Almalinux-builder in linux-job by default" (#5901)
4e5ad04 
Reverts #5898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZainRizvi ZainRizvi ZainRizvi approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atalman @ZainRizvi @facebook-github-bot