[bots][ez] Add testing for webhookToDynamo bot#5869
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added 2 commits
November 6, 2024 11:17
huydhn
approved these changes
Nov 6, 2024
Contributor
huydhn
left a comment
There was a problem hiding this comment.
Having more test is definitely better than having no tests I think :)
clee2000
added a commit
that referenced
this pull request
Nov 8, 2024
Upgrading cuz I think it's a good idea to be on a more recent version. idk what the consequences will be Theres also next 15.something but that came out really recently and next-auth doesn't list it as a compatible version octokit types changed which is why webhookToDyanamo looks different. Functionality should be the same, mostly just type changes + casting, and we have tests after #5869 Cousin to #5862 but does both slightly less and slightly more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for webhookToDynamo bot so I can be certain that nothing changes when I upgrade octokit
The tests do not have every webhook event, but most of that bot's code is the same for each event
zipped file of expected results (zipped to reduce size and to reduce confusion when grepping for things)
No functional changes, just saving the current outputs/results