Skip to content

Upload benchmark results in v3 schema to ossci-benchmarks S3 bucket#5845

Merged
huydhn merged 3 commits intomainfrom
upload-benchmark-results-s3
Nov 7, 2024
Merged

Upload benchmark results in v3 schema to ossci-benchmarks S3 bucket#5845
huydhn merged 3 commits intomainfrom
upload-benchmark-results-s3

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented Oct 31, 2024 •
edited
Loading

After #5839, it's time to upload the GHA to upload to S3. I'll update the S3 lambda replicator in a separate PR.

Testing

  • Locally
# Backward compatibility, upload to both dynamoDB and S3 for v2 schema
$python upload_benchmark_results.py --benchmark-results-dir benchmark-results-dir-for-testing/v2 --schema-version v2 --dry-run
INFO:root:Uploading benchmark-results-dir-for-testing/v2/android-artifacts-31017223108.json to dynamoDB (v2)
INFO:root:Writing 16 documents to DynamoDB torchci-oss-ci-benchmark
INFO:root:Upload benchmark-results-dir-for-testing/v2/android-artifacts-31017223108.json to s3://ossci-benchmarks/v2/pytorch/executorch/12345/31017223108/android-artifacts-31017223108.json
INFO:root:Uploading benchmark-results-dir-for-testing/v2/android-artifacts-31017223431.json to dynamoDB (v2)
INFO:root:Writing 12 documents to DynamoDB torchci-oss-ci-benchmark
INFO:root:Upload benchmark-results-dir-for-testing/v2/android-artifacts-31017223431.json to s3://ossci-benchmarks/v2/pytorch/executorch/12345/31017223431/android-artifacts-31017223431.json

# We use only S3 for v3 schema
$python upload_benchmark_results.py --benchmark-results-dir benchmark-results-dir-for-testing/v3 --schema-version v3
INFO:root:Upload benchmark-results-dir-for-testing/v3/mock.json to s3://ossci-benchmarks/v3/pytorch/pytorch/1/1/mock.json

@huydhn huydhn requested a review from a team October 31, 2024 04:42
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 4:47am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2024
huydhn added a commit to pytorch/executorch that referenced this pull request Oct 31, 2024
@huydhn
Testing PR for pytorch/test-infra#5845
21f384a
@huydhn huydhn mentioned this pull request Oct 31, 2024
Closed
@huydhn huydhn merged commit c661a34 into main Nov 7, 2024
@huydhn huydhn deleted the upload-benchmark-results-s3 branch November 7, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clee2000 clee2000 clee2000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huydhn @clee2000 @facebook-github-bot