Merged
Conversation
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
09371ac to
57e7baf
Compare
malfet
reviewed
Nov 29, 2023
malfet
requested changes
Nov 29, 2023
Contributor
malfet
left a comment
There was a problem hiding this comment.
Why any changes to setup-binary-builds action is necessary? Are you saying that we build both wheels and conda packages for domains using conda dependencies?
Contributor
Author
|
We used similar code for python 3.11, which was cleaned recently: 3be953c |
Contributor
Author
Created an issue here: #4773 to get rid of conda env when running wheel builds. |
malfet
reviewed
Nov 30, 2023
test test test upodate_assets
1c8dc94 to
16d0270
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up after pytorch/pytorch#112882.
Please note conda-build and conda is not available yet for Python=3.12. Hence building wheels under Conda Python 3.9.