Skip to content

Add Unittests for Build Matrix Generation#4386

Merged
osalpekar merged 3 commits intopytorch:mainfrom
osalpekar:build_matrix_tests
Jul 13, 2023
Merged

Add Unittests for Build Matrix Generation#4386
osalpekar merged 3 commits intopytorch:mainfrom
osalpekar:build_matrix_tests

Conversation

@osalpekar
Copy link
Copy Markdown
Contributor

@osalpekar osalpekar commented Jul 12, 2023

Adds Unittests for build matrix generation. This PR does a couple things:

  • Refactors the build matrix generation script to have a general-purpose function that returns the matrix as a python dict
  • Adds JSON files in tools/tests/assets that contain the output of running the generation script with common configs (not comprehensive atm but covers the most common 6 configurations - Wheels/Conda across the 3 OS's with CUDA enabled)
  • Adds Unittests that call the generic matrix generation function and compares it with the serialized matrices in the JSON files.

The unittests will be picked up by the GHA job in tests.yml.

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 12, 2023

@osalpekar is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2023
@osalpekar osalpekar merged commit c13f64b into pytorch:main Jul 13, 2023
osalpekar added a commit that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants