Exclude unstable jobs when evaluating red % metrics#4246
Merged
huydhn merged 1 commit intopytorch:mainfrom Jun 2, 2023
Merged
Conversation
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
clee2000
approved these changes
Jun 1, 2023
PaliC
pushed a commit
that referenced
this pull request
Jun 5, 2023
After pytorch/pytorch#102426 and pytorch/pytorch#102784 landed, unstable jobs are now hidden correctly on HUD https://hud.pytorch.org and also won't block PR. Previously, this was done by moving unstable jobs to an unstable workflow. Now unstable jobs will stay in the same workflow, but have `unstable` in their names. This is very similar to how `rerun_disabled_tests` are ignored atm. ### Testing https://torchci-git-fork-huydhn-ignore-unstable-jobs-fbopensource.vercel.app/metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After pytorch/pytorch#102426 and pytorch/pytorch#102784 landed, unstable jobs are now hidden correctly on HUD https://hud.pytorch.org and also won't block PR. Previously, this was done by moving unstable jobs to an unstable workflow. Now unstable jobs will stay in the same workflow, but have
unstablein their names.This is very similar to how
rerun_disabled_testsare ignored atm.Testing
https://torchci-git-fork-huydhn-ignore-unstable-jobs-fbopensource.vercel.app/metrics