Skip to content

Support an optional job name filter (regex) in the OSS alerting#2109

Merged
izaitsevfb merged 2 commits intomainfrom
oss-alerts-add-job-name-filter
Feb 6, 2023
Merged

Support an optional job name filter (regex) in the OSS alerting#2109
izaitsevfb merged 2 commits intomainfrom
oss-alerts-add-job-name-filter

Conversation

@izaitsevfb
Copy link
Copy Markdown
Contributor

As a prerequisite for pytorch/pytorch#93991 adding the possibility to specify a job name filter for the OSS alert generation mechanism.

The idea is to be able to specify JOB_NAME_REGEX in

WITH_FLAKY_TEST_ALERT: ${{ matrix.with_flaky_test_alerting }}
to restrict alerting only to the desired set of jobs.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
torchci ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 7:07PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2023
Co-authored-by: Nikita Shulga <nshulga@fb.com>
@izaitsevfb izaitsevfb merged commit 66bd3b4 into main Feb 6, 2023
@izaitsevfb izaitsevfb deleted the oss-alerts-add-job-name-filter branch February 6, 2023 19:08
izaitsevfb added a commit that referenced this pull request Feb 10, 2023
…2681)

Brunt of the work for pytorch/pytorch#93991

Changes:
1. Adds a script (`binary_size_validation.py `) to perform wheel size
fetching and validation using given rules.
2. Includes the specific job pattern from the builder repo to create
alerts.
3. Fixes a minor bug in `check_alerts.py` (regression from #2109)

A separate PR will schedule the script periodic execution in the
pytorch/builder repo (TODO). The builder repo is chosen as compromise,
as `test-infra` doesn't have HUD enabled as of now (alerts do not work).


----

### Brief docs for `binary_size_validation.py ` (separate readme is
included):

#### Installation

```bash
pip install -r requirements.txt
```

#### Usage
    
```bash
# print help
python binary_size_validation.py --help

# print sizes of the all items in the index
python binary_size_validation.py --url https://download.pytorch.org/whl/nightly/torch/

# fail if any of the torch2.0 wheels are larger than 900MB
python binary_size_validation.py --url https://download.pytorch.org/whl/nightly/torch/ --include "torch-2\.0"  --threshold 900

# fail if any of the latest nightly pypi wheels are larger than 750MB
python binary_size_validation.py --include "pypi" --only-latest-version --threshold 750
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants