Deal with undefined tensors in unbind backward#9995
Closed
t-vi wants to merge 2 commits intopytorch:masterfrom
Closed
Deal with undefined tensors in unbind backward#9995t-vi wants to merge 2 commits intopytorch:masterfrom
t-vi wants to merge 2 commits intopytorch:masterfrom
Conversation
When only part of the outputs of unbind are used in a backward, the gradients for the others are undefined. This sets those to zero in to_tensor_list. Fixes: pytorch#9977
ssnl
reviewed
Jul 30, 2018
|
|
||
| std::vector<Tensor> to_tensor_list(const variable_list& variables) { | ||
| return fmap(variables, [](const Variable &v) { return static_cast<Tensor>(v); } ); | ||
| IntList sizes; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
...to make the code clearer. Based on a review comment by SsnL, thank you!
Collaborator
|
The failure looks like that it might be related to the change. Can you see if it reproduces locally? |
Collaborator
Author
|
The TestCuda.test_index? I cannot reproduce that and in fact I think that might just be the build failure du jour then (a randomly chosen adjacent build had that, too). Could you ask for a rebuild, please? If that fails, I'll take another look. |
Collaborator
|
@pytorchbot retest this please |
Collaborator
Author
|
Thanks! Seems to have worked. :) |
ssnl
approved these changes
Aug 9, 2018
apaszke
approved these changes
Aug 9, 2018
soumith
approved these changes
Aug 9, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
Summary: When only part of the outputs of unbind are used in a backward, the gradients for the others are undefined. This sets those to zero in to_tensor_list. Fixes: pytorch#9977 Pull Request resolved: pytorch#9995 Differential Revision: D9239610 Pulled By: soumith fbshipit-source-id: eb8d1b3f2b4e615449f9d856e10b946910df9147
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: When only part of the outputs of unbind are used in a backward, the gradients for the others are undefined. This sets those to zero in to_tensor_list. Fixes: pytorch#9977 Pull Request resolved: pytorch#9995 Differential Revision: D9239610 Pulled By: soumith fbshipit-source-id: eb8d1b3f2b4e615449f9d856e10b946910df9147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When only part of the outputs of unbind are used in a backward,
the gradients for the others are undefined. This sets those
to zero in to_tensor_list.
Fixes: #9977