Optimize reduce ops for 2d and 3d#9992
Closed
xiaomengy wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
9111e6d to
5ef5552
Compare
5ef5552 to
e05e820
Compare
e05e820 to
c0870d7
Compare
c0870d7 to
efc66c9
Compare
efc66c9 to
34e463d
Compare
34e463d to
9ff7a2c
Compare
9ff7a2c to
fb7a457
Compare
fb7a457 to
5d64454
Compare
Member
|
Seems hip still has compilation errors, and incurs segmentation fault on |
Contributor
|
@petrex @ashishfarmer @rohithkrn We probably should also hipify math_hip, otherwise we can never catch up the speed of @BIT-silence |
Contributor
|
thanks, we will look into this PR |
5d64454 to
2939a43
Compare
2939a43 to
80ee667
Compare
Contributor
Author
|
I will update this PR to make build and test passed. But I cannot guarantee they can be optimized as well as the CUDA side. |
Contributor
Author
|
@pytorchbot test this please |
80ee667 to
29fc3fd
Compare
29fc3fd to
e0465ca
Compare
8232ff2 to
db179a2
Compare
db179a2 to
56bf03d
Compare
56bf03d to
ea8962c
Compare
ea8962c to
3ad095f
Compare
3ad095f to
b5729bf
Compare
b5729bf to
9da015b
Compare
9da015b to
b6c7439
Compare
b6c7439 to
50a0383
Compare
50a0383 to
f8eabe4
Compare
f8eabe4 to
aba4871
Compare
aba4871 to
0e86c69
Compare
Summary: Pull Request resolved: pytorch#9992 Optimize reduce ops for 2d and 3d Differential Revision: D9042505 fbshipit-source-id: 43cbc1a8aab0d33a90a369752d2617cc564957c7
0e86c69 to
3ee7fca
Compare
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9992 Optimize reduce ops for 2d and 3d Reviewed By: houseroad Differential Revision: D9042505 fbshipit-source-id: 62af2125aa6439106293e59bdf6a2b920792fd2d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Optimize reduce ops for 2d and 3d
Differential Revision: D9042505