[buckbuild.bzl] Fix dep handling in cross-builds#99826

Merged

facebook-github-bot merged 1 commit intopytorch:mainfrom

andrewjcg:export-D44960349

Apr 26, 2023

Contributor

andrewjcg commented Apr 23, 2023 •

edited

Loading

Summary:
Use a helper rule to handle select()s in deps.

Reviewed By: r1mikey

Differential Revision: D44960349

pytorch-bot bot commented Apr 23, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99826

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5e35a15:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla bot commented Apr 23, 2023 •

edited

Loading

The committers listed above are authorized under a signed CLA.

✅ login: andrewjcg (351702efb7c8bab656dac4c985dd5f09a4e443ee)

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Apr 23, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349

andrewjcg force-pushed the export-D44960349 branch from 82daa52 to a317a44 Compare

April 24, 2023 19:41

Contributor

facebook-github-bot commented Apr 24, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349

andrewjcg changed the title ~~[aarch64][tools/build_defs/third_party/fbcode_defs.bzl] Fix dep handling in cross-builds~~ [buckbuild.bzl] Fix dep handling in cross-builds

andrewjcg force-pushed the export-D44960349 branch from a317a44 to 756cd89 Compare

April 25, 2023 15:40

Contributor

facebook-github-bot commented Apr 25, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349

andrewjcg force-pushed the export-D44960349 branch from 756cd89 to 8fa3148 Compare

April 25, 2023 15:55

Contributor

facebook-github-bot commented Apr 25, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349

andrewjcg force-pushed the export-D44960349 branch from 8fa3148 to 351702e Compare

April 25, 2023 16:29

Contributor

facebook-github-bot commented Apr 25, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349

andrewjcg force-pushed the export-D44960349 branch from 351702e to 9754bc1 Compare

April 25, 2023 19:15

Contributor

facebook-github-bot commented Apr 25, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349

1 similar comment

Contributor

facebook-github-bot commented Apr 25, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349

andrewjcg force-pushed the export-D44960349 branch from 9754bc1 to 47a2323 Compare

April 25, 2023 19:27

malfet approved these changes

View reviewed changes

malfet added the ciflow/periodic label

andrewjcg force-pushed the export-D44960349 branch from 47a2323 to f2ccceb Compare

April 25, 2023 22:41

Contributor

facebook-github-bot commented Apr 25, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349


          [aarch64][tools/build_defs/third_party/fbcode_defs.bzl] Fix dep handl…

5e35a15

…ing in cross-builds (pytorch#14)

Summary:
X-link: facebookexternal/supernova_manufacturing#14

Pull Request resolved: pytorch#99826

When using buck2, use a `select()` to format fbcode tp2 deps, rather
than inferring the parse-time host platform, which breaks in cross-builds.

Test Plan: `buck2 build mode/opt-split-dwarf -c fbcode.platform010_clang=15 -c fbcode.arch=aarch64 fbsource//xplat/assistant/oacr/native_thrift_service:oacr_native_service_cli`

Reviewed By: r1mikey, malfet

Differential Revision: D44960349

fbshipit-source-id: 1043b39b9a57fab6a353e1736c195440715f4e06

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D44960349

andrewjcg force-pushed the export-D44960349 branch from f2ccceb to 5e35a15 Compare

April 26, 2023 00:13

facebook-github-bot merged commit 0b1b063 into pytorch:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic fb-exported