Fix BlobStatRegistry HIP BlobStatGetter registration issue#9973
Closed
bddppq wants to merge 1 commit intopytorch:masterfrom
Closed
Fix BlobStatRegistry HIP BlobStatGetter registration issue#9973bddppq wants to merge 1 commit intopytorch:masterfrom
bddppq wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
All CI passed, ninja land to unbreak master. |
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
) Summary: This was introduced in pytorch#9826 following the corresponding cuda file context_gpu.cu file, tests have passed in the PR, at that point master was 94439d7. However during the long landing process, a new master commit aebf3b4 has come in that removed the `CAFFE_KNOWN_TYPE(Tensor<HIPContext>)` in context_hip.cc file, which then has broken the HIP BlobStatGetter, and we did NOT run tests again during merge and so when pytorch#9826 later landed to master the rocm tests start breaking. Pull Request resolved: pytorch#9973 Differential Revision: D9040671 Pulled By: bddppq fbshipit-source-id: f3b16cabaf681fc0535ca733db0b48430868f922
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
) Summary: This was introduced in pytorch#9826 following the corresponding cuda file context_gpu.cu file, tests have passed in the PR, at that point master was 94439d7. However during the long landing process, a new master commit aebf3b4 has come in that removed the `CAFFE_KNOWN_TYPE(Tensor<HIPContext>)` in context_hip.cc file, which then has broken the HIP BlobStatGetter, and we did NOT run tests again during merge and so when pytorch#9826 later landed to master the rocm tests start breaking. Pull Request resolved: pytorch#9973 Differential Revision: D9040671 Pulled By: bddppq fbshipit-source-id: f3b16cabaf681fc0535ca733db0b48430868f922
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in #9826 following the corresponding cuda file context_gpu.cu file, tests have passed in the PR, at that point master was 94439d7. However during the long landing process, a new master commit aebf3b4 has come in that removed the
CAFFE_KNOWN_TYPE(Tensor<HIPContext>)in context_hip.cc file, which then broke the HIP BlobStatGetter, and we did NOT run tests again during merge and so when #9826 later landed to master the rocm tests start breaking.