Use Retainable as base class for StorageImpl#9956
Closed
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
Closed
Use Retainable as base class for StorageImpl#9956cpuhrsch wants to merge 1 commit intopytorch:masterfrom
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
Conversation
cpuhrsch
commented
Jul 27, 2018
aten/src/ATen/THLongStorageView.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Jul 30, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch/pytorch#9956 Reviewed By: gchanan Differential Revision: D9066103 Pulled By: cpuhrsch fbshipit-source-id: 1a5a2ace306308707add3d0e0c1fc861f5c79705
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 31, 2018
Summary: Pull Request resolved: pytorch#9956 Reviewed By: gchanan Differential Revision: D9066103 Pulled By: cpuhrsch fbshipit-source-id: 1a5a2ace306308707add3d0e0c1fc861f5c79705
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9956 Reviewed By: gchanan Differential Revision: D9066103 Pulled By: cpuhrsch fbshipit-source-id: 1a5a2ace306308707add3d0e0c1fc861f5c79705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.