Closed
Conversation
4b11835 to
380cf08
Compare
Summary: Pull Request resolved: pytorch#9890 Minor cleanups for Graph.h to make it more consistent with our style guide Also fix opt/device.cc and binary_match_test.cc to not access subgraph.nodes_ which is now private Differential Revision: D9017108 fbshipit-source-id: e12037ca36eb3d05f20aaa79e367c8a5f2557b30
Contributor
|
@pytorchbot retest this please |
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 31, 2018
Summary: Pull Request resolved: pytorch#9890 Minor cleanups for Graph.h to make it more consistent with our style guide Also fix opt/device.cc and binary_match_test.cc to not access subgraph.nodes_ which is now private Reviewed By: bwasti Differential Revision: D9017108 fbshipit-source-id: 9f5cba4a2cd2a452a955005f4704f6c120bbc1d5
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9890 Minor cleanups for Graph.h to make it more consistent with our style guide Also fix opt/device.cc and binary_match_test.cc to not access subgraph.nodes_ which is now private Reviewed By: bwasti Differential Revision: D9017108 fbshipit-source-id: 9f5cba4a2cd2a452a955005f4704f6c120bbc1d5
This was referenced Apr 14, 2025
This was referenced Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Minor cleanups for Graph.h to make it more consistent with our style guide
Differential Revision: D9017108