Skip to content

Remove Broadcast.py.#9843

Closed
gchanan wants to merge 2 commits intopytorch:masterfrom
gchanan:rm_broadcast_py2
Closed

Remove Broadcast.py.#9843
gchanan wants to merge 2 commits intopytorch:masterfrom
gchanan:rm_broadcast_py2

Conversation

@gchanan
Copy link
Contributor

@gchanan gchanan commented Jul 25, 2018

I don't think this file is used anywhere, I guess we'll find out!

(Weirdly this failed lint on one of my PRs even though it shouldn't).

facebook-github-bot
facebook-github-bot reviewed Jul 25, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang
Copy link
Contributor

ezyang commented Jul 25, 2018

@pytorchbot retest this please

@ezyang
Copy link
Contributor

ezyang commented Jul 26, 2018

Seems like it's being used:

21:35:15 [ 85%] Building CXX object caffe2/CMakeFiles/test_parallel.dir/__/aten/src/ATen/test/test_parallel.cpp.o
21:35:15 Traceback (most recent call last):
21:35:15   File "tools/setup_helpers/generate_code.py", line 111, in <module>
21:35:15     main()
21:35:15   File "tools/setup_helpers/generate_code.py", line 107, in main
21:35:15     options.install_dir)
21:35:15   File "tools/setup_helpers/generate_code.py", line 81, in generate_code
21:35:15     from tools.nnwrap import generate_wrappers as generate_nn_wrappers
21:35:15   File "/var/lib/jenkins/workspace/tools/nnwrap/__init__.py", line 1, in <module>
21:35:15     from .generate_wrappers import generate_wrappers, wrap_function, import_module
21:35:15   File "/var/lib/jenkins/workspace/tools/nnwrap/generate_wrappers.py", line 4, in <module>
21:35:15     from ..cwrap import cwrap
21:35:15   File "/var/lib/jenkins/workspace/tools/cwrap/__init__.py", line 1, in <module>
21:35:15     from .cwrap import cwrap
21:35:15   File "/var/lib/jenkins/workspace/tools/cwrap/cwrap.py", line 5, in <module>
21:35:15     from .plugins import ArgcountChecker, OptionalArguments, ArgumentReferences, \
21:35:15   File "/var/lib/jenkins/workspace/tools/cwrap/plugins/__init__.py", line 435, in <module>
21:35:15     from .Broadcast import Broadcast
21:35:15 ImportError: No module named 'tools.cwrap.plugins.Broadcast'

facebook-github-bot
facebook-github-bot reviewed Jul 26, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
@gchanan @jramseyer
Remove Broadcast.py. (pytorch#9843)
53353d2 
Summary:
I don't think this file is used anywhere, I guess we'll find out!

(Weirdly this failed lint on one of my PRs even though it shouldn't).
Pull Request resolved: pytorch#9843

Differential Revision: D9003949

Pulled By: gchanan

fbshipit-source-id: 26d580d1e7cdd30e82e5f4176244e51fd7cd616d
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@gchanan
Remove Broadcast.py. (pytorch#9843)
7284959 
Summary:
I don't think this file is used anywhere, I guess we'll find out!

(Weirdly this failed lint on one of my PRs even though it shouldn't).
Pull Request resolved: pytorch#9843

Differential Revision: D9003949

Pulled By: gchanan

fbshipit-source-id: 26d580d1e7cdd30e82e5f4176244e51fd7cd616d
@ezyang ezyang added the merged label Jun 26, 2019
@rodrigoberriel rodrigoberriel mentioned this pull request Sep 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gchanan @ezyang @facebook-github-bot