add .gitattributes for EOL conversion.#9813
Closed
shkit wants to merge 1 commit intopytorch:masterfrom
shkit:add-gitattributes
Closed
add .gitattributes for EOL conversion.#9813shkit wants to merge 1 commit intopytorch:masterfrom shkit:add-gitattributes
shkit wants to merge 1 commit intopytorch:masterfrom
shkit:add-gitattributes
Conversation
peterjc123
approved these changes
Jul 25, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@peterjc123 is this good to go? |
Collaborator
|
@weiyangfb Yes, please merge it. |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: `.bat` file's EOL is LF, so a build is failed on some Windows machines. To fix this, add `.gitattributes` and set batch file's EOL to CRLF. Discussion is in pytorch#9677. Pull Request resolved: pytorch#9813 Differential Revision: D9026486 Pulled By: soumith fbshipit-source-id: 341eaa677c35f8476a7eda1bac9827385072eb29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.batfile's EOL is LF, so a build is failed on some Windows machines.To fix this, add
.gitattributesand set batch file's EOL to CRLF.Discussion is in #9677.