[jit][easy] add missing quotes in namedtuple forwardref tests#97736
Closed
davidberard98 wants to merge 1 commit intogh/davidberard98/180/basefrom
Closed
[jit][easy] add missing quotes in namedtuple forwardref tests#97736davidberard98 wants to merge 1 commit intogh/davidberard98/180/basefrom
davidberard98 wants to merge 1 commit intogh/davidberard98/180/basefrom
Conversation
Follow-up to #96933. This test was intended to have quotes around the type annotations for the attributes of the NamedTuple. This PR adds this missing quotes. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97736
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 071c0fb: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eellison
approved these changes
Mar 28, 2023
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Follow-up to #96933. This test was intended to have quotes around the
type annotations for the attributes of the NamedTuple. This PR adds this
missing quotes.