Merge THStorage into at::Storage#9772

Closed

cpuhrsch wants to merge 17 commits intopytorch:masterfrom

cpuhrsch:tmmerge

Contributor

cpuhrsch commented Jul 24, 2018

No description provided.

cpuhrsch requested review from apaszke, colesbury, ezyang, gchanan, soumith and zdevito as code owners

July 24, 2018 17:20

cpuhrsch force-pushed the tmmerge branch 3 times, most recently from 8edfa40 to 66eda70 Compare

July 24, 2018 20:26

ezyang reviewed

View reviewed changes

aten/src/ATen/Storage.cpp Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/Storage.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/Storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/Storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/Storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/Storage.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/Utils.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/THC/THCGeneral.h.in Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

cpuhrsch force-pushed the tmmerge branch from 66eda70 to 2c878e3 Compare

July 24, 2018 20:45

ezyang reviewed

View reviewed changes

aten/src/TH/generic/THStorage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/TH/generic/THStorage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/templates/TypeDerived.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/templates/Tensor.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

aten/src/ATen/templates/TensorDense.cpp Outdated

This comment was marked as off-topic.

Sign in to view

ezyang requested changes

View reviewed changes

Contributor

ezyang left a comment

There are some memory errors in this patch, fix those first and if your stated error persists we can debug more ;)

cpuhrsch requested review from ebetica and goldsborough as code owners

July 25, 2018 17:58

cpuhrsch force-pushed the tmmerge branch 3 times, most recently from ce8b9d1 to d6d1c30 Compare

July 25, 2018 19:05

gchanan reviewed

View reviewed changes

Contributor

gchanan left a comment

you have onnx changes, I assume you don't want that.

Contributor

ezyang commented Jul 26, 2018

@pytorchbot retest this please

Contributor

ezyang commented Jul 26, 2018

you got build failures:

22:16:08 /var/lib/jenkins/workspace/aten/src/ATen/native/cuda/Gesv.cu(107): error: class "at::Storage" has no member "data"
22:16:08 
22:16:08 /var/lib/jenkins/workspace/aten/src/ATen/native/cuda/Gesv.cu(108): error: class "at::Storage" has no member "data"
22:16:08 
22:16:08 /var/lib/jenkins/workspace/aten/src/ATen/native/cuda/Gesv.cu(109): error: class "at::Storage" has no member "data"
22:16:08 
22:16:08 /var/lib/jenkins/workspace/aten/src/ATen/native/cuda/Gesv.cu(110): error: class "at::Storage" has no member "data"
22:16:08           detected during instantiation of "void at::native::applyGesv<scalar_t>(at::Tensor &, at::Tensor &, std::vector<int64_t, std::allocator<int64_t>>) [with scalar_t=double]" 
22:16:08 (134): here
22:16:08

Contributor

bddppq commented Jul 27, 2018

@pytorchbot retest this please

cpuhrsch force-pushed the tmmerge branch from 45f66be to 14f8fca Compare

July 27, 2018 16:04

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

cpuhrsch added 16 commits

July 27, 2018 09:11


          Merge THStorage into at::Storage

8da5073


          Use device for backend

4e6421f


          Remove dead code

ab35fe6


          StorageImpl

d2279b0


          Add retain call to Storage constructor

d52a26b


          Responding to review

9a97fa9


          Deal with type

80b189e


          Remove default StorageImpl constructor

703f870


          Small fixes and also Windows

8cd2e9f


          Remove call for retain during storage constructor

5fc50e2


          Finish checked_cast_storage and lint

c7c9581


          resizable not resizeable

b3e782a


          Fix for checked_cast_storage

8be0beb


          No onnx

e7fc945


          Deal with MAGMA

321356b


          Small fixes

0b5cfea

cpuhrsch force-pushed the tmmerge branch from 14f8fca to 0b5cfea Compare

July 27, 2018 16:11

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          AT_API for Windows

49a54a1

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot closed this in

ef9801f

zdevito pushed a commit to zdevito/ATen that referenced this pull request


          Merge THStorage into at::Storage

157c3a4

Summary: Pull Request resolved: pytorch/pytorch#9772

Reviewed By: ezyang

Differential Revision: D9019375

Pulled By: cpuhrsch

fbshipit-source-id: d5185e29747929d648e4260db4967452cd40f563

jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request


          Merge THStorage into at::Storage

a4f741b

Summary: Pull Request resolved: pytorch#9772

Reviewed By: ezyang

Differential Revision: D9019375

Pulled By: cpuhrsch

fbshipit-source-id: d5185e29747929d648e4260db4967452cd40f563

goodlux pushed a commit to goodlux/pytorch that referenced this pull request


          Merge THStorage into at::Storage

fb9fbc8

Summary: Pull Request resolved: pytorch#9772

Reviewed By: ezyang

Differential Revision: D9019375

Pulled By: cpuhrsch

fbshipit-source-id: d5185e29747929d648e4260db4967452cd40f563

ezyang added the merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gchanan gchanan left review comments

facebook-github-bot facebook-github-bot left review comments

ezyang ezyang approved these changes

apaszke Awaiting requested review from apaszke

colesbury Awaiting requested review from colesbury

soumith Awaiting requested review from soumith

zdevito Awaiting requested review from zdevito

ebetica Awaiting requested review from ebetica

goldsborough Awaiting requested review from goldsborough

pietern Awaiting requested review from pietern

teng-li Awaiting requested review from teng-li

Labels

None yet