Fixes xcode 10 beta 4 compile error#9748
Closed
williamtwilson wants to merge 1 commit intopytorch:masterfrom
Closed
Fixes xcode 10 beta 4 compile error#9748williamtwilson wants to merge 1 commit intopytorch:masterfrom
williamtwilson wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: When building iOS apps with a caffe2 dependency, we were seeing the `caffe2/caffe2/mobile/contrib/ios/mpscnn/mpscnn.mm:33:17: error: method 'copyWithZone:' in protocol 'NSCopying' not implemented [-Werror,-Wprotocol]`. This fixes it by implementing a shallow copy with that method. Differential Revision: D8954332 fbshipit-source-id: 990b995a697bb0132cadab437cde177af2724e16
rahulpat
approved these changes
Jul 24, 2018
Contributor
|
@pytorchbot retest this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@williamtwilson is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: When building iOS apps with a caffe2 dependency, we were seeing the `caffe2/caffe2/mobile/contrib/ios/mpscnn/mpscnn.mm:33:17: error: method 'copyWithZone:' in protocol 'NSCopying' not implemented [-Werror,-Wprotocol]`. This fixes it by implementing a shallow copy with that method. Pull Request resolved: pytorch#9748 Reviewed By: jerryzh168 Differential Revision: D8954332 Pulled By: williamtwilson fbshipit-source-id: 0cd44408257c0bd3f4ffb80312ea9d13d13e5ff3
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: When building iOS apps with a caffe2 dependency, we were seeing the `caffe2/caffe2/mobile/contrib/ios/mpscnn/mpscnn.mm:33:17: error: method 'copyWithZone:' in protocol 'NSCopying' not implemented [-Werror,-Wprotocol]`. This fixes it by implementing a shallow copy with that method. Pull Request resolved: pytorch#9748 Reviewed By: jerryzh168 Differential Revision: D8954332 Pulled By: williamtwilson fbshipit-source-id: 0cd44408257c0bd3f4ffb80312ea9d13d13e5ff3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: When building iOS apps with a caffe2 dependency, we were seeing the
caffe2/caffe2/mobile/contrib/ios/mpscnn/mpscnn.mm:33:17: error: method 'copyWithZone:' in protocol 'NSCopying' not implemented [-Werror,-Wprotocol]. This fixes it by implementing a shallow copy with that method.Differential Revision: D8954332