Remove implicit ArrayRef -> vector conversion#9740
Closed
smessmer wants to merge 2 commits intopytorch:masterfrom
Closed
Remove implicit ArrayRef -> vector conversion#9740smessmer wants to merge 2 commits intopytorch:masterfrom
smessmer wants to merge 2 commits intopytorch:masterfrom
Conversation
91590bc to
df6a203
Compare
Contributor
Author
|
@pytorchbot retest this please |
df6a203 to
15735a4
Compare
15735a4 to
35a2544
Compare
35a2544 to
a2829a0
Compare
a2829a0 to
bc07de9
Compare
bc07de9 to
b84a846
Compare
b84a846 to
af46276
Compare
af46276 to
b9fda09
Compare
b9fda09 to
3d2166b
Compare
3d2166b to
c4a4290
Compare
c4a4290 to
1980466
Compare
1980466 to
fc56ef1
Compare
fc56ef1 to
7d46876
Compare
7d46876 to
eb5591b
Compare
Differential Revision: D8926785 fbshipit-source-id: e52fa362c3d60eb04e0a8038c748def22ab7f48f
Summary: Pull Request resolved: pytorch#9740 - Remove implicit ArrayRef -> vector conversion - Fix 4 call sites that accidentally did an implicit expensive vector conversion but wouldn't have needed to - Remove explicit vector conversion from 4 call sites that also didn't need to do that Differential Revision: D8961693 fbshipit-source-id: 7a7c38a02bb4e9eb605887bde78f69cf2197e429
eb5591b to
6f4d23b
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 1, 2018
Summary: Pull Request resolved: pytorch/pytorch#9740 - Remove implicit ArrayRef -> vector conversion - Fix 4 call sites that accidentally did an implicit expensive vector conversion but wouldn't have needed to - Remove explicit vector conversion from 4 call sites that also didn't need to do that Reviewed By: ezyang Differential Revision: D8961693 fbshipit-source-id: 980da9f988083c0072497f9dbcbbf6f516fa311c
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9740 - Remove implicit ArrayRef -> vector conversion - Fix 4 call sites that accidentally did an implicit expensive vector conversion but wouldn't have needed to - Remove explicit vector conversion from 4 call sites that also didn't need to do that Reviewed By: ezyang Differential Revision: D8961693 fbshipit-source-id: 980da9f988083c0072497f9dbcbbf6f516fa311c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: First commit of this stack is reviewed in #9610 , only the second commit is important. Review this on Phabricator to only see the changes of this diff without the previous stack.
Summary:
Differential Revision: D8961693