[codemod] Match parameter names and = default#9737
Closed
goldsborough wants to merge 1 commit intopytorch:masterfrom
Closed
[codemod] Match parameter names and = default#9737goldsborough wants to merge 1 commit intopytorch:masterfrom
goldsborough wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
@pytorchbot retest this please |
2 similar comments
Contributor
Author
|
@pytorchbot retest this please |
Contributor
|
@pytorchbot retest this please |
4446d38 to
0dcc8de
Compare
Contributor
Author
|
|
Contributor
|
@pytorchbot retest this please |
Export compile_commands.json
0dcc8de to
be02b98
Compare
Contributor
Author
|
@ezyang are we ok to merge this once tests pass? |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Jul 30, 2018
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 31, 2018
Summary:
More clang tidy cleanups in `torch/csrc`. This time:
1. `hicpp-use-equals-default` recommends `= default` instead of `{}` for constructors/destructors. This is better practice because it expresses the intent better (https://stackoverflow.com/questions/6502828/what-does-default-mean-after-a-class-function-declaration)
2. `readability-inconsistent-declaration-parameter-name` enforces that parameter names in the declaration match parameter names in the definition. This is just generally useful and can prevent confusion and bugs.
Also updated my script a little bit.
apaszke ezyang
Pull Request resolved: pytorch#9737
Differential Revision: D9069069
Pulled By: goldsborough
fbshipit-source-id: f7b3f3a4eb4c9fadc30425a153566d3b613a41ae
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary:
More clang tidy cleanups in `torch/csrc`. This time:
1. `hicpp-use-equals-default` recommends `= default` instead of `{}` for constructors/destructors. This is better practice because it expresses the intent better (https://stackoverflow.com/questions/6502828/what-does-default-mean-after-a-class-function-declaration)
2. `readability-inconsistent-declaration-parameter-name` enforces that parameter names in the declaration match parameter names in the definition. This is just generally useful and can prevent confusion and bugs.
Also updated my script a little bit.
apaszke ezyang
Pull Request resolved: pytorch#9737
Differential Revision: D9069069
Pulled By: goldsborough
fbshipit-source-id: f7b3f3a4eb4c9fadc30425a153566d3b613a41ae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More clang tidy cleanups in
torch/csrc. This time:hicpp-use-equals-defaultrecommends= defaultinstead of{}for constructors/destructors. This is better practice because it expresses the intent better (https://stackoverflow.com/questions/6502828/what-does-default-mean-after-a-class-function-declaration)readability-inconsistent-declaration-parameter-nameenforces that parameter names in the declaration match parameter names in the definition. This is just generally useful and can prevent confusion and bugs.Also updated my script a little bit.
@apaszke @ezyang