[C++ API] Rename embedding variable to weight#9720
Closed
goldsborough wants to merge 1 commit intopytorch:masterfrom
Closed
[C++ API] Rename embedding variable to weight#9720goldsborough wants to merge 1 commit intopytorch:masterfrom
goldsborough wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ebetica
approved these changes
Jul 23, 2018
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: I renamed the variable in the `Embedding` module from `weight` to `table` a few months ago, because it seemed like a more meaningful name. Turns out it's not such a good idea because it deviates from PyTorch, which unnecessarily breaks C++->Python translated code. ebetica ezyang apaszke Pull Request resolved: pytorch#9720 Differential Revision: D8955647 Pulled By: goldsborough fbshipit-source-id: 77228b07d2b733866e8cdecaa6d0686eef4cc3ea
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: I renamed the variable in the `Embedding` module from `weight` to `table` a few months ago, because it seemed like a more meaningful name. Turns out it's not such a good idea because it deviates from PyTorch, which unnecessarily breaks C++->Python translated code. ebetica ezyang apaszke Pull Request resolved: pytorch#9720 Differential Revision: D8955647 Pulled By: goldsborough fbshipit-source-id: 77228b07d2b733866e8cdecaa6d0686eef4cc3ea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed the variable in the
Embeddingmodule fromweighttotablea few months ago, because it seemed like a more meaningful name. Turns out it's not such a good idea because it deviates from PyTorch, which unnecessarily breaks C++->Python translated code.@ebetica @ezyang @apaszke