Closed
Conversation
Summary: D8722560 was landed with some build errors, unfortunately the c10 code isn't part of contbuild yet. Fixing them. Differential Revision: D8954141 fbshipit-source-id: e2deaed9b19583a016dbea518aaaa599c32f877a
ezyang
approved these changes
Jul 23, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Can we get this code in contbuild, then?
Contributor
Author
|
It will be with #9360 The issue is only that the template currently isn't instantiated because there aren't any c10 ops yet. |
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9717 D8722560 was landed with some build errors, unfortunately the c10 code isn't part of contbuild yet. Fixing them. Differential Revision: D8954141 fbshipit-source-id: 2a082fb8041626e45ccd609f37a8ef807f6dad8a
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9717 D8722560 was landed with some build errors, unfortunately the c10 code isn't part of contbuild yet. Fixing them. Differential Revision: D8954141 fbshipit-source-id: 2a082fb8041626e45ccd609f37a8ef807f6dad8a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D8722560 was landed with some build errors, unfortunately the c10 code isn't part of contbuild yet.
Fixing them.
Differential Revision: D8954141