Re-enable test_ops_jit on Windows (#96859)#96931
Closed
huydhn wants to merge 11 commits intopytorch:masterfrom
Closed
Re-enable test_ops_jit on Windows (#96859)#96931huydhn wants to merge 11 commits intopytorch:masterfrom
huydhn wants to merge 11 commits intopytorch:masterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96931
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b9e594d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Mar 17, 2023
Contributor
kit1980
left a comment
There was a problem hiding this comment.
Rename PR to avoid confusion, it's not a true revert.
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
Fixes pytorch/pytorch#96858 Pull Request resolved: pytorch/pytorch#96931 Approved by: https://github.com/kit1980
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
Fixes pytorch/pytorch#96858 Pull Request resolved: pytorch/pytorch#96931 Approved by: https://github.com/kit1980
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 18, 2023
…9389) This issue starts to show up recently https://github.com/pytorch/pytorch/actions/runs/4724983231/jobs/8385139626 and I'm pretty sure that the root cause is Windows Defender as I did a similar fix on Windows CI a while ago #96931. Without this, Windows binary build could fail flakily when Windows Defender chooses to delete/quarantine a file in the temp folder. Pull Request resolved: #99389 Approved by: https://github.com/weiwangmeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96858