Hide all other fields in THTensor (#9591)#9683
Closed
ezyang wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Summary: This pops off `refcount_`, `storage_`, `storage_offset_`; there are now no more direct accesses to these fields and we can make them private (with appropriate friending). Stacked on pytorch#9561 Pull Request resolved: pytorch#9591 Reviewed By: gchanan Differential Revision: D8922246 Pulled By: gchanan fbshipit-source-id: 63dd3eb9787c460373c3cc507886d3b0a30e7542
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 22, 2018
Summary: Pull Request resolved: pytorch/pytorch#9683 This pops off `refcount_`, `storage_`, `storage_offset_`; there are now no more direct accesses to these fields and we can make them private (with appropriate friending). Stacked on #9561 Pull Request resolved: pytorch/pytorch#9591 Reviewed By: SsnL Differential Revision: D8922246 Pulled By: ezyang fbshipit-source-id: dfae023d790e29ce652e2eab9a1628bbe97b318d
gchanan
reviewed
Jul 24, 2018
|
|
||
| #define THTensor_(NAME) TH_CONCAT_4(TH,Real,Tensor_,NAME) | ||
|
|
||
| #ifdef __cplusplus |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9683 This pops off `refcount_`, `storage_`, `storage_offset_`; there are now no more direct accesses to these fields and we can make them private (with appropriate friending). Stacked on pytorch#9561 Pull Request resolved: pytorch#9591 Reviewed By: SsnL Differential Revision: D8922246 Pulled By: ezyang fbshipit-source-id: dfae023d790e29ce652e2eab9a1628bbe97b318d
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9683 This pops off `refcount_`, `storage_`, `storage_offset_`; there are now no more direct accesses to these fields and we can make them private (with appropriate friending). Stacked on pytorch#9561 Pull Request resolved: pytorch#9591 Reviewed By: SsnL Differential Revision: D8922246 Pulled By: ezyang fbshipit-source-id: dfae023d790e29ce652e2eab9a1628bbe97b318d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pops off
refcount_,storage_,storage_offset_; there are now no more direct accesses to these fields and we can make them private (with appropriate friending).Stacked on #9561
Pull Request resolved: #9591
Reviewed By: gchanan
Differential Revision: D8922246
Pulled By: gchanan