Add 1x1 specialization for conv with NCHW order#9671
Closed
xiaomengy wants to merge 1 commit intopytorch:masterfrom
Closed
Add 1x1 specialization for conv with NCHW order#9671xiaomengy wants to merge 1 commit intopytorch:masterfrom
xiaomengy wants to merge 1 commit intopytorch:masterfrom
Conversation
8e83fd3 to
fc093f1
Compare
Contributor
Author
|
Some benchmark on CPU with N = 128, C = 128, H = 32, W = 32, M = 128, G = 4, kernel = 1 |
fc093f1 to
6104500
Compare
6104500 to
afb3870
Compare
afb3870 to
043be2e
Compare
043be2e to
38c7a0d
Compare
38c7a0d to
4f7e50b
Compare
4f7e50b to
be43279
Compare
be43279 to
e1ef4b8
Compare
e1ef4b8 to
242b9a0
Compare
242b9a0 to
274ec56
Compare
274ec56 to
cd76050
Compare
cd76050 to
13972ba
Compare
Summary: Pull Request resolved: pytorch#9671 Add 1x1 specialization for conv with NCHW order Differential Revision: D8944686 fbshipit-source-id: 6a96813f3d9f0d47799391172214e3bf9d938f22
13972ba to
ac96d91
Compare
yinghai
reviewed
Jul 23, 2018
Contributor
yinghai
left a comment
There was a problem hiding this comment.
Could you provide some comment on what the difference is between batchedgemm and batchedstridedgemm?
| @@ -255,7 +255,7 @@ class BatchMatMulOp final : public Operator<Context> { | |||
|
|
|||
| // TODO(T23893772): doing this in a loop is likely going to be slow on GPU | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
approved these changes
Jul 23, 2018
Member
houseroad
left a comment
There was a problem hiding this comment.
LGTM.
If using OSS, we can always do git clang-format on the staging files.
Mercurial may also support this.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9671 Add 1x1 specialization for conv with NCHW order Reviewed By: houseroad Differential Revision: D8944686 fbshipit-source-id: 94bf44f69498b1934b7dfff4c0e989342c7bb61c
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9671 Add 1x1 specialization for conv with NCHW order Reviewed By: houseroad Differential Revision: D8944686 fbshipit-source-id: 94bf44f69498b1934b7dfff4c0e989342c7bb61c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add 1x1 specialization for conv with NCHW order
Differential Revision: D8944686